CREATE tests
#1572
Merged
CREATE tests
#1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GAS_NEXT issues for now
OlivierBBB
force-pushed
the
CREATE-tests
branch
from
59c91cd to
581a7ab
Compare
We unconditionally import account.nonce() to the RLPADDR module. We must therefore also include the nonce to disambiguate duplicate CREATE2's
...test/java/net/consensys/linea/zktracer/instructionprocessing/createTests/failure/Create.java
Outdated
Show resolved
Hide resolved
| case THIRTY_TWO -> program.push(0x20); | ||
| case MSIZE -> program.op(MSIZE); | ||
| case MAX -> program.push("ff".repeat(32)); | ||
| } |
There was a problem hiding this comment.
Here you may consider to do the following.
Modify the enum to:
public enum SizeParameter {
ZERO(0),
TWELVE(12), // - 3 - 1
THIRTEEN(13), // - 3 + 0
FOURTEEN(14), // - 3 + 1
THIRTY_TWO(32),
MSIZE,
MAX;
public int getValue() {
if (this == MSIZE || this == MAX) {
throw new UnsupportedOperationException("...");
}
return this.value;
}
public boolean isAnyOf(SizeParameter... sizeParameters) {
for (SizeParameter sizeParameter : sizeParameters) {
if (this == sizeParameter) {
return true;
}
}
return false;
}
public boolean willRaiseException() {
return this.isAnyOf(MAX);
}
}
Then, the code above would become:
switch (sizeParameter) {
case MSIZE -> program.op(MSIZE);
case MAX -> program.push("ff".repeat(32));
deafult -> program.push(sizeParameter.getValue();
}
However, it is not a big deal to leave it as it is, but this could be a good approach for the future.
There was a problem hiding this comment.
Another approach may be using Either, where you basically either store an int or another type, that could be an enum, but it is probably not worth facing that complexity for this simple scenario.
There was a problem hiding this comment.
also, what translates to an integer may have a more meaningful name rather than ZERO, TWELVE etc.
…DE of the createe if the createe gets loaded into the trace
down to 7 failing CREATE tests, none of which (AFAICT) related to the CREATE's themselves.
OlivierBBB
commented
Dec 6, 2024
| @@ -625,7 +625,7 @@ public void traceContextEnter(MessageFrame frame) { | |||
| frameType, | |||
| newChildContextNumber(), | |||
| this.deploymentStatusOf(frame.getContractAddress()), | |||
| frame.getValue(), | |||
| frame.getApparentValue(), | |||
There was a problem hiding this comment.
Important bug fix, required e.g. for DELEGATECALL to provide the CallFrame with the correct value i.e. callValue
Otherwise the project doesn't work properly with updated constraints
triggers scenario/CALL_FAILURE_WILL_REVERT using a self call and only 2 or 3 iterations (and blows up for STATICCALL) with an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.